[MPlayer-dev-eng] [PATCH] vobsub fix

[191919]

Thanks for your clarification. I just modified the code then ran "svn
diff > file.patch".

2010/7/20 Erik Auerswald <auerswal at unix-ag.uni-kl.de>:
> Hi,
>
> [...top posting repaired...]
>
> On Tue, Jul 20, 2010 at 07:05:42PM +0800, 191919 wrote:
>> 2010/7/20 Carl Eugen Hoyos <cehoyos at ag.or.at>:
>> > 191919 <191919 <at> gmail.com> writes:
>> >
>> >> mplayer crashes when processing some idx+sub file, e.g:
>> >>
>> >> Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS.idx
>> >> Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS.sub
>> >>
>> >> Here goes the patch. It works fine with all previously problematic video clips.
>> >
>> > Apart from "both sample and backtrace missing": Please do not mix functional and
>> > cosmetic changes in your patch (=remove the re-indentation from your patch).
>> >
>> I didn't change the indentation.
>
> You did: you added the if condition and adjusted the indentation of the
> code that is now inside the then block.
>
> To clearly see that the added if is the only change, you should not
> re-indent the unchanged code. This will violate the coding standard
> after applying this patch, but there are only functional changes that
> can be reviewed.
>
> The re-indentation to adhere to coding standards should be done in an
> additional patch. This patch should contain whitespace changes only
> (can be checked using patch --ignore-whitespace).
>
> If you could provide a short example file (not the whole episode)
> exhibiting the crash, others could verify the error and your fix. That's
> what Carl Eugen asked for.
>
> I think your patch is correct (it seems to prevent accessing a negative
> index array entry). I do not know if this is the bug or if this should
> have been caught earlier. Anyway, I'm no MPlayer developer, I'm just
> trying clarify the issue. :-)
>
> Thanks,
> Erik
> --
> Simplicity is prerequisite for reliability.
>                        -- Edsger W. Dijkstra
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>