[MPlayer-dev-eng] [PATCH] vobsub fix

[191919]

I didn't change the indentation.

I configured with "./configure --enable-debug" in a Snow Leopard 10.6.4.

The backtrace:

(gdb) r /mv/2.5men/S04/*S04E01*.avi
Starting program: /box/mplayer/mplayer /mv/2.5men/S04/*S04E01*.avi
Reading symbols for shared libraries
.+++++++++++++++++++++++++++++++++++++....................................................................................
done
MPlayer SVN-r31758-4.2.1 (C) 2000-2010 MPlayer Team
Reading symbols for shared libraries . done

Playing /mv/2.5men/S04/Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS.avi.

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x00000021018891e0
0x0000000100051b4e in vobsub_open (name=0x101631780
"/mv/2.5men/S04/Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS",
ifo=<value temporarily unavailable, due to optimizations>, force=0,
spu=0x1008e4050) at vobsub.c:1038
1038	                                            pkt->pts100 = last->pts100;
(gdb) where
#0  0x0000000100051b4e in vobsub_open (name=0x101631780
"/mv/2.5men/S04/Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS",
ifo=<value temporarily unavailable, due to optimizations>, force=0,
spu=0x1008e4050) at vobsub.c:1038
#1  0x00000001000105d6 in main (argc=<value temporarily unavailable,
due to optimizations>, argv=0x7fff5fbff920) at mplayer.c:3241

queue->current_index is 0, so &queue->packets[queue->current_index -
1] points to a disaster:

(gdb) print queue->current_index
$1 = 0

2010/7/20 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> 191919 <191919 <at> gmail.com> writes:
>
>> mplayer crashes when processing some idx+sub file, e.g:
>>
>> Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS.idx
>> Two.And.A.Half.Men.S04E01.Working.For.Caligula.DVDRip.XviD-ORPHEUS.sub
>>
>> Here goes the patch. It works fine with all previously problematic video clips.
>
> Apart from "both sample and backtrace missing": Please do not mix functional and
> cosmetic changes in your patch (=remove the re-indentation from your patch).
>
> Carl Eugen
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>