[MPlayer-dev-eng] [PATCH] Fixing dvd:// support

[Olivier Rolland]

Hi,

On Sat, Jun 26, 2010 at 11:17 AM, Olivier Rolland
<billl at users.sourceforge.net> wrote:
> Hi,
>
> On Tue, May 11, 2010 at 3:38 PM, Nico Sabbi <nicola.sabbi at poste.it> wrote:
>> I gave them a quick look few days ago and they seemed to be correct;
>> yet I remember that I implemented that seeking mechanism for some
>> reason that -guess what?-  I don't remember.
>>
>> I didn't test the code (sorry, but my work is taking away all my time)
>> but my  heart says it's correct, so if it works I approve the commit.
>
> Can you give them a deeper look so that they can be available for rc4 ?

Those patches have been submitted more than 2 months ago and they have
never been fully reviewed. I can easily understand that nico does not
have a lot of time these days and that dvdnav has a higher priority,
but as long as you decided to take the maintainership of libdvdread,
you should at least fix issues when patches are available. So, please,
believe Nico when he says the patches are correct and commit them.

Regards,

Olivier