[MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX

[Reimar Döffinger]

On Thu, Jul 15, 2010 at 11:48:18PM -0700, Paul Huwe wrote:
> > Also, for this kind of thing it is much preferable to
> > provide it via get_property.
> > (see mp_properties table in command.c).
> 
> Umm, okay. How does one extract mp_property elements via the slave interface? (Or am I misunderstanding you?)

get_property "property_name"
and I think this is documented in DOCS/tech/slave.txt, improvements welcome

> > Lastly, I have some doubts about doing a fallback: first,
> > as you do it it is incomplete,
> > failing for audio-only. It also discards the information
> > whether a stream pts is
> > available, which makes the difference between
> > reliable/non-warp-around timestamps
> > (DVD) or not (playing the same vob after copying it from
> > the DVD).
> 
> Okay.. do you have a suggestion for what needs to be done here for codebase implementation? Frankly, I only really cared about getting a (at least somewhat) proper time from DVDs... some alternative to get_time_pos to help with dvd timing/seekbar timing/etc.. I'm just trying to get a slave accessible, sub second, stream time into the mplayer codebase.

Just return "not available" when the stream_pts is not set, and application
then knows it has to get the timing from somewhere else and it might
have those other issues.
(though strictly speaking the stream time necessarily will wrap around
somewhere, the more important point probably is that stream_pts might
be set and sometimes not set for some reason and in that case your
"fallback" to sh_video->pts or whatever would cause random bouncing
around of the time returned with no indication to the application
which one is the "proper" time).