[MPlayer-dev-eng] [PATCH] Bluray support through libbluray

[Benjamin Zores]

Le 4 juil. 2010 à 08:19, Ergzay <ergzay at gmail.com> a écrit :

>
> On Jul 3, 2010, at 7:09 PM, Reimar Döffinger wrote:
>
>> On Sat, Jul 03, 2010 at 10:47:56PM +0200, Benjamin Zores wrote:
>>> On Sat, Jul 3, 2010 at 10:14 PM, Dâniel Fraga <fragabr at gmail.com 
>>> > wrote:
>>>> On Sat, 3 Jul 2010 16:44:09 +0200
>>>> Benjamin Zores <ben at geexbox.org> wrote:
>>>>
>>>>> Done.
>>>>> See new patch.
>>>>
>>>>       Benjamin, thanks for the patch. I tried it with latest
>>>> libbluray from git repository and I got this:
>>>>
>>>> cc -MD -MP -Wstrict-prototypes -Wmissing-prototypes -Wundef - 
>>>> Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after- 
>>>> statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith - 
>>>> Wredundant-decls -O4 -march=native -mtune=native -pipe -ffast- 
>>>> math -fomit-frame-pointer -Wstrict-prototypes -Wmissing- 
>>>> prototypes -Wundef -Wdisabled-optimization -Wno-pointer-sign - 
>>>> Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch - 
>>>> Wpointer-arith -Wredundant-decls -O4 -march=native -mtune=native - 
>>>> pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE - 
>>>> D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I.  - 
>>>> D_REENTRANT -I/usr/X11/include   -I/usr/local/include/artsc - 
>>>> pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/ 
>>>> include  -I/usr/local/include/freetype2 -I/usr/local/include -I/ 
>>>> usr/local/include   -c -o stream/stream_bluray.o stream/ 
>>>> stream_bluray.c
>>>> stream/stream_bluray.c: In function 'bluray_stream_open':
>>>> stream/stream_bluray.c:105:5: error: 'BD_TITLE_INFO' undeclared  
>>>> (first use in this function)
>>>> stream/stream_bluray.c:105:5: note: each undeclared identifier is  
>>>> reported only once for each function it appears in
>>>> stream/stream_bluray.c:105:20: error: 'info' undeclared (first  
>>>> use in this function)
>>>> stream/stream_bluray.c:106:5: warning: ISO C90 forbids mixed  
>>>> declarations and code
>>>> stream/stream_bluray.c:148:24: error: 'ti' undeclared (first use  
>>>> in this function)
>>>> stream/stream_bluray.c:149:9: warning: ISO C90 forbids mixed  
>>>> declarations and code
>>>> make: *** [stream/stream_bluray.o] Error 1
>>>>
>>>>       Maybe it's trivial? Thanks.
>>>
>>> Yeah, replace the BD_ by BLURAY_
>>> I made libbluray guys change to BLURAY_* for consistency this
>>> afternoon and I have another patch for that.
>>
>> Should you maybe extend the configure check to make sure it is a  
>> version
>> we can use and possibly print some hint about which version is  
>> required?
>> I also always appreciate it when people double-check not to add any
>> warnings :-).
>> Otherwise I have no objections...
>
> On Mac OS X 10.6 here. I just tried a compile with the patch and it  
> fails on compile. Comes about because it can't find a malloc.h.  
> Probably some #ifdef needed.
>
> cc -MD -MP -Wstrict-prototypes -Wmissing-prototypes -Wundef - 
> Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after- 
> statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant- 
> decls -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame- 
> pointer -Wstrict-prototypes -Wmissing-prototypes -Wundef -Wdisabled- 
> optimization -Wno-pointer-sign -Wdeclaration-after-statement - 
> std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 - 
> march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer - 
> D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE - 
> Ilibdvdread4 -mdynamic-no-pic -falign-loops=16 -shared-libgcc -I.  - 
> DPIC  -I/usr/X11/include -I/usr/local/include/ -I/usr/local/include/ 
> SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE -I/usr/X11/include/freetype2 -I/ 
> usr/X11/include -c -o stream/stream_bluray.o stream/stream_bluray.c
> stream/stream_bluray.c:31:20: error: malloc.h: No such file or  
> directory
> make: *** [stream/stream_bluray.o] Error 1

Can you try to send a patch to fix it on OSX ? I really can't test here.

Ben



>
> Matthew Lindner
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng