[MPlayer-dev-eng] [PATCH] Bluray support through libbluray

[Reimar Döffinger]

On Sat, Jul 03, 2010 at 10:47:56PM +0200, Benjamin Zores wrote:
> On Sat, Jul 3, 2010 at 10:14 PM, Dâniel Fraga <fragabr at gmail.com> wrote:
> > On Sat, 3 Jul 2010 16:44:09 +0200
> > Benjamin Zores <ben at geexbox.org> wrote:
> >
> >> Done.
> >> See new patch.
> >
> >        Benjamin, thanks for the patch. I tried it with latest
> > libbluray from git repository and I got this:
> >
> > cc -MD -MP -Wstrict-prototypes -Wmissing-prototypes -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -Wstrict-prototypes -Wmissing-prototypes -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I.  -D_REENTRANT -I/usr/X11/include   -I/usr/local/include/artsc -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include  -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include   -c -o stream/stream_bluray.o stream/stream_bluray.c
> > stream/stream_bluray.c: In function 'bluray_stream_open':
> > stream/stream_bluray.c:105:5: error: 'BD_TITLE_INFO' undeclared (first use in this function)
> > stream/stream_bluray.c:105:5: note: each undeclared identifier is reported only once for each function it appears in
> > stream/stream_bluray.c:105:20: error: 'info' undeclared (first use in this function)
> > stream/stream_bluray.c:106:5: warning: ISO C90 forbids mixed declarations and code
> > stream/stream_bluray.c:148:24: error: 'ti' undeclared (first use in this function)
> > stream/stream_bluray.c:149:9: warning: ISO C90 forbids mixed declarations and code
> > make: *** [stream/stream_bluray.o] Error 1
> >
> >        Maybe it's trivial? Thanks.
> 
> Yeah, replace the BD_ by BLURAY_
> I made libbluray guys change to BLURAY_* for consistency this
> afternoon and I have another patch for that.

Should you maybe extend the configure check to make sure it is a version
we can use and possibly print some hint about which version is required?
I also always appreciate it when people double-check not to add any
warnings :-).
Otherwise I have no objections...