[MPlayer-dev-eng] what happened to the blu-ray support

[Reimar Döffinger]

On Fri, Jul 02, 2010 at 11:10:24PM -0300, Dâniel Fraga wrote:
> On Sat, 3 Jul 2010 01:51:48 +0200
> Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> > Ok, since your appreciation for that kind of thing is so high,
> > here is a "working" patch for PGS.
> > Now find someone to clean it up properly, after all I have done the
> > "useful feature" part.
> > (No, this is not even very, very remotely ok for SVN, as anyone trying
> > to use it will probably notice before the end of the movie, among
> > more "philosophical" things).
> > And yes, it also needs -demuxer lavf.
> > 
> 
> 	Thank you very much Reimar, but what do you mean by "clean it
> up"? To make it compile or to clean the code? Because I already have
> some compiler issues:
> 
> cc -MD -MP -Wstrict-prototypes -Wmissing-prototypes -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -Wstrict-prototypes -Wmissing-prototypes -Wundef -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I.  -D_REENTRANT -I/usr/X11/include   -I/usr/local/include/artsc -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include  -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include   -c -o mpcommon.o mpcommon.c
> mpcommon.c: In function 'update_subtitles':
> mpcommon.c:209:56: warning: left-hand operand of comma expression has no effect
> mpcommon.c:210:56: warning: left-hand operand of comma expression has no effect
> mpcommon.c:209:41: warning: statement with no effect
> mpcommon.c:211:56: error: expected ';' before ')' token
> mpcommon.c:211:56: error: expected statement before ')' token
> mpcommon.c:219:41: warning: passing argument 4 of 'spudec_set_paletted' from incompatible pointer type
> spudec.h:39:6: note: expected 'uint32_t *' but argument is of type 'uint8_t *'
> mpcommon.c:187:21: warning: unused variable 'res'
> make: *** [mpcommon.o] Error 1

How the ... did that happen.
No, with "clean up" I mean doing the actual work, the kind of stuff you have been
complaining about us doing: Making sure it works smoothly and reliably, making
sure it is maintainable, making sure people will still be able to understand it
in 5 years...