[MPlayer-dev-eng] [PATCH] [RFC] correct type for some declarations in windef

[Diego Biurrun]

On Thu, Jul 01, 2010 at 07:32:14PM +0200, Reimar Döffinger wrote:
> On Thu, Jul 01, 2010 at 12:31:18PM +0200, Diego Biurrun wrote:
> > On Wed, Jun 30, 2010 at 07:42:16PM +0200, Reimar Döffinger wrote:
> > > On Wed, Jun 30, 2010 at 12:46:54PM +0200, Diego Biurrun wrote:
> > > > The patch I'm attaching is a wild guess.  I know zilch about Windows
> > > > programming, so I'm at a loss to guess the correct type.  Better
> > > > suggestions and pointers in the right direction welcome.
> > > > 
> > > > This will fix a ton of the following annoying warnings:
> > > > 
> > > > In file included from libmpcodecs/ad_realaud.c:34:
> > > > ./loader/wine/windef.h:304: warning: function declaration isn't a prototype
> > > > ./loader/wine/windef.h:305: warning: function declaration isn't a prototype
> > > > In file included from libmpcodecs/ad_realaud.c:34:
> > > > ./loader/wine/windef.h:437: warning: function declaration isn't a prototype
> > > > ./loader/wine/windef.h:438: warning: function declaration isn't a prototype
> > > 
> > > This is wrong, since FARPROC is supposed to be used for all kinds
> > > of function pointers, it is not supposed to say anything about which
> > > kinds of arguments the function takes.
> > > My suggestion would be to comment them out (possibly with an explanation
> > > of the issue).
> > 
> > You mean comment out as in the attached patch?  That won't compile..
> 
> Right.
> Well, I don't mind your original patch, but I think a few things should be done
> 1) make sure it does not break compilation on Windows

I committed the patch, we shall soon hear reports I guess :)

> 2) add a comment that those declarations are not really correct with "void"

Done.

> 3) ensure it does not add new warnings (e.g. in module.c)

It does not.

Diego