[MPlayer-dev-eng] [PATCH] New option to disable key events

[Reimar Döffinger]

On Thu, Jul 01, 2010 at 03:31:00PM -0400, Vlad Seryakov wrote:
> On Jul 1, 2010, at 3:01 PM, Reimar Döffinger wrote:
> 
> > On Thu, Jul 01, 2010 at 02:58:03PM -0400, Vlad Seryakov wrote:
> >> On Jul 1, 2010, at 12:45 PM, Reimar Döffinger wrote:
> >> 
> >>> On Thu, Jul 01, 2010 at 06:03:05PM +0200, Attila Kinali wrote:
> >>>> I would rename the option to -x11-nokeyinput as it applies only to x11
> >>>> based vos (and the console will still accept key input), but otherwise
> >>>> it seems ok.
> >>>> 
> >>>> Reimar, is the patch ok to apply?
> >>> 
> >>> Uh, -input nodefault-bindings
> >>> was added for exactly that purpose...
> >> 
> >> This is different, with this option X11 events will be accepted but silently swallowed instead of going to the parent window. For -slave integration events better be propagated up to the chain.
> > 
> > -wid on Windows already passes events on. If that's not the case on
> > Linux it probably makes sense to change that - possibly even
> > make it configurable, but if that is the purpose, nokeyinput
> > is a truly horrible name for it.
> > Not to mention that it should work for Windows as well.
> -nomouseinput implemented on X11 and Windows completely different, -nokeyinput follows it closely, using same technique and similar name. 

The principle shouldn't be to take the worst implementation mistakes and inconsistencies and copy them.

> And X11 events are not passed like on Windows, mplayer with -wid grabs key events for that window, this is foreign window, at least having an option to disable key grabbing would be fair

-wid disables now all that kind of stuff. For this particular problem your patch
just wasn't really a proper solution, things like StructureNotify etc.
have similar issues.