[MPlayer-dev-eng] [PATCH] [RFC] correct type for some declarations in windef

[Diego Biurrun]

On Wed, Jun 30, 2010 at 07:42:16PM +0200, Reimar Döffinger wrote:
> On Wed, Jun 30, 2010 at 12:46:54PM +0200, Diego Biurrun wrote:
> > The patch I'm attaching is a wild guess.  I know zilch about Windows
> > programming, so I'm at a loss to guess the correct type.  Better
> > suggestions and pointers in the right direction welcome.
> > 
> > This will fix a ton of the following annoying warnings:
> > 
> > In file included from libmpcodecs/ad_realaud.c:34:
> > ./loader/wine/windef.h:304: warning: function declaration isn't a prototype
> > ./loader/wine/windef.h:305: warning: function declaration isn't a prototype
> > In file included from libmpcodecs/ad_realaud.c:34:
> > ./loader/wine/windef.h:437: warning: function declaration isn't a prototype
> > ./loader/wine/windef.h:438: warning: function declaration isn't a prototype
> 
> This is wrong, since FARPROC is supposed to be used for all kinds
> of function pointers, it is not supposed to say anything about which
> kinds of arguments the function takes.
> My suggestion would be to comment them out (possibly with an explanation
> of the issue).

You mean comment out as in the attached patch?  That won't compile..

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: windef2.diff
Type: text/x-diff
Size: 1348 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100701/6321b2b0/attachment.diff>