[MPlayer-dev-eng] [PATCH] Multiple problems with tfields filter

[Reimar Döffinger]

On Sun, Jan 31, 2010 at 04:34:47PM -0500, John Lindgren wrote:
> I recently started using the tfields=1 filter for deinterlacing when
> watching DVD's, and noticed some problems, and while trying to fix them,
> I stumbled on some more.  A couple of these are merely for the sake of
> correctness; a couple are noticeable only when the filter is applied to
> a non-planar video format, i.e. when using OpenGL output instead of Xv.

Please send a separate patch per issue.

>       * Optimize deint() by reducing number of operations in innermost
>         loop.

I sure can believe it is faster, but that's certainly not hard if you replace
a kind of threshold-and-filter algorithm by a simple linear blend.

>       * Fix continue_buffered_image() to recalculate pts value when "i"
>         counter changes.

Since that's an inaccurate hack anyway it shouldn't be duplicated, e.g.
a function like
double adjust_pts(double pts, int delay)
or so might be ok.

> By the way, MPlayer's manual page needs updating.  Contrary to the
> manual page, tfields *does* work in MPlayer, not only MEncoder, and does
> not need the -fps command line switch to work correctly.

Not really, it just happens to work if your vo does vsync and the vsync
frequency is about twice the original frame rate.
Might be good enough for most, but calling it "work" is a bit of a stretch.