[MPlayer-dev-eng] [PATCH] view stereoscopic videos

[Diego Biurrun]

On Fri, Jan 29, 2010 at 10:49:50AM +0100, Gordon Schmidt wrote:
> On Fri, Jan 29, 2010 at 09:09:27AM +0100, Diego Biurrun wrote:
>>>> Please use K&R coding style for new files, no tabs, no trailing
>>>> whitespace, 4 spaces indentation.
>>> I hope the code is to your convenience now.
>>
>> No.  At a first glance, case should be indented at the same level as
>> switch, { go on the next line for function declarations.
>>
>> This is a recurring problem, so please tell me how you went about
>> this?  Where and how did you research what K&R style consists of?
> Sorry, just had a quick look at http://en.wikipedia.org/wiki/Indent_style
> and  
> http://www.cas.mcmaster.ca/~carette/SE3M04/2004/slides/CCodingStyle.html 
> that had quite some differences.

Looks identical to me...

> Maybe i'm just using the wrong documentations. In this case you should  
> provide a binding set of rules within the repository and i will change  
> the style on the next time i have to change something in the source.

Yes, it seems that a succinct explanation of K&R style is not so easy
to find.  I'll try to write something up for our documentation.

> Btw: How big is the part of the mplayer source that complies to this K&R 
> rules anyway?

100% of newly-added code since two years or so ago.  Much of the rest
is a mess, that's why we're enforcing a proper style for new files.

Diego