[MPlayer-dev-eng] [PATCH]Parse audio in mkv

[Reimar Döffinger]

On Tue, Jan 26, 2010 at 07:30:16PM +0100, Carl Eugen Hoyos wrote:
> Attached patch "fixes" roundup issue 1703.
> 
> I will apply if nobody objects, Carl Eugen

> Index: libmpdemux/demux_mkv.c
> ===================================================================
> --- libmpdemux/demux_mkv.c	(revision 30437)
> +++ libmpdemux/demux_mkv.c	(working copy)
> @@ -1682,6 +1682,7 @@
>    mkv_demuxer_t *mkv_d = (mkv_demuxer_t *) demuxer->priv;
>    sh_audio_t *sh_a = new_sh_audio_aid(demuxer, track->tnum, aid);
>    demux_packet_t *dp;
> +  sh_a->needs_parsing = 1;

I am almost certain this is a broken file (assuming it is not really
a bug in the decoder).
I am fine with making mp3lib the default again, it is faster
and we have found and fixed some issues with decoding via
FFmpeg.
I don't think it is a good idea to make the mkv demuxer do parsing,
at least not in such a broad way.