[MPlayer-dev-eng] [PATCH] view stereoscopic videos

[Reimar Döffinger]

On Sun, Jan 24, 2010 at 01:50:13PM +0100, Gordon Schmidt wrote:
> >>+//==macros==//
> >>+#define MIN(X,Y)                ((X) < (Y) ? (X) : (Y))
> >>+#define MAX(X,Y)                ((X) < (Y) ? (Y) : (X))
> >
> >FFMIN/FFMAX
> >
> Just out of curiosity, what do you mean by this comment? Is it about
> the name of the macros or about the fact i redefined them instead of
> including them from somewhere else? I only use them for clipping
> anyway, so it all comes down to your next remark anyway.

Those are defined by libavutil and should be reused in MPlayer
for consistency, also since ideally some days these filters will
one way or another become part of FFmpeg's libavfilter.

> The anaglyphs are different to the rest. I'm not sure how to reduce
> code size in this cases. They just use different macros for the
> calculation of each pixel, but i shouldn't use a switch within the
> loops. This would certainly slow down the code.

If you come up with a patch that has at least a more sane size so
it is possible to find the difficult parts in all of the trivial
ones I'm sure I or someone else will help you think of better
solutions - or if there are none a bit of duplicated code is
acceptable - but only as much as necessary.

> Another general question: shall i provide further patches as diffs
> from last revision or should i provide incremental patches based on
> my last patch?

Always provide diffs against the latest SVN version (preferably created
by svn diff).