[MPlayer-dev-eng] [rfc][patch] mplayer-mt, -lavdopts threads=2 and -vo gl failure on mpeg-1 and theora

[Uoti Urpala]

On Sat, 2010-01-23 at 15:43 +0300, Yuriy Kaminskiy wrote:
> On 20.01.2010 18:41, Uoti Urpala wrote:
> > On Tue, 2010-01-19 at 16:49 +0200, Uoti Urpala wrote:
> >> On Tue, 2010-01-19 at 17:16 +0300, Yuriy Kaminskiy wrote:
> >>> With my patch and separate rendering thread enabled (-vo gl:...:thread) - no
> >>> problem with theora, no problem with mpeg-1 & -noslices.
> >> It should be possible to fix this without such an extensive patch,
> > It should be fixed in git now.
> Thanks! Tested, seems work. I've actually was more worried, that some future
> change in h264 mt decoder may break -vo gl too ;-)

There's less need for threading for other codecs, but I think it's at
least nice to be able to enable threading without needing to be careful
about exactly which codecs are used.

> So, 1) this won't happen anyway 2) other codecs fixed [and without unnecessary
> overhead] 3) I better understand pthreads ;-)

I still see some failures in multithreaded FFmpeg-mt Theora decoding
after seeks though. I think that's not an MPlayer-side problem however
(haven't investigated it so far, and it's not a high priority as I don't
care much about Theora).