[MPlayer-dev-eng] [patch] cache2.c: when fork() fails, mplayer can kill every user process

Yuriy Kaminskiy yumkam at mail.ru
Sat Jan 23 12:39:39 CET 2010


On 23.01.2010 14:19, Reimar Döffinger wrote:
> On Wed, Jan 20, 2010 at 03:43:49AM +0300, Yuriy Kaminskiy wrote:
>> On 19.01.2010 23:55, Reimar Döffinger wrote:
>> Anyway, your patch clearly did not fixed this bug.
> Sorry about that, I applied some mixture of different things.
> I you know of something that still doesn't work please report it.
Yep ;-) cache_uninit won't be called at all when cache_pid == 0
(stream.c:453:free_stream()). I've called cache_uninit directly from
stream_enable_cache failure path for a reason ;-) [well, maybe free_stream
should be fixed instead; but there were also another reason: don't leave
half-initialized and unusable stream->cache*, even temporarily].




More information about the MPlayer-dev-eng mailing list