[MPlayer-dev-eng] [RFC][PATCH] Add support for 12-bit color mode.

[Dominik 'Rathann' Mierzejewski]

Hi!

On Monday, 18 January 2010 at 17:09, Janusz Krzysztofik wrote:
> Hi,
> 
> While trying to use mplayer on my ARM OMAP based Amstrad Delta (E3) 
> videophone, I found this software not compatible with the 12-bit LCD display 
> my device is equipped with. Fbdev and fbdev2 video output drivers did not work 
> at all, while others like directfb, for example, gave incorrect colors.
> 
> The patch tries to extend mplayer with RGB12 aka RGB444 pixel format handling. 
> It works for me with fbdev and fbdev2, selecting required color conversion 
> filters automatically. It also works with directfb when provided with "-vf 
> format=bgr12" option. I was not able to get correct results using sdl, 
> neither with qtopia (wrong collors) nor fbcon (not working at all) drivers.

Thanks for your contribution. However, it cannot be accepted as is. See below.

> All new color conversion functions are supposed to work correctly except for 
> dithering that I was not able to develop correct table values for by myself.
>  
> Some changes to video output drivers and other modules that I was not able to 
> test are probably wrong or even not applicable.
> 
> Created against mplayer-1.0rc2.

Patches should be made against current SVN, not a release that is a couple of
years old. The code has changed significantly since then.

[...]
> diff -uprd MPlayer-1.0rc2/libavcodec/flicvideo.c.orig MPlayer-1.0rc2/libavcodec/flicvideo.c

Patches for libav* and libswscale should be sent to ffmpeg-devel, as these
libraries are part of FFmpeg.

Please read patch submission guidelines for MPlayer and FFmpeg before resubmitting
your patches again. (http://www.mplayerhq.hu/DOCS/tech/patches.txt for MPlayer
and http://ffmpeg.org/developer.html for FFmpeg).

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan