[MPlayer-dev-eng] [PATCH] make use of dxguid instead of hardcoded references

[Gianluigi Tiesi]

On Sun, Jan 17, 2010 at 09:26:37AM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 17, 2010 at 03:36:21AM +0100, Gianluigi Tiesi wrote:
> > I've got a problem while building on win32 with SDL static lib,
> > sdl needs dxguid (the check will fail)
> 
> My SDL version doesn't, until I understand why I don't like this
> at all.
> If you overrride the configure check, will it compile?

configure will fail with sdl static due to missing ldxguid in check

for _ld_tmp in "-lSDL" "-lSDL -lpthread" "-lSDL -lwinmm -lgdi32" ; do

if adding dxguid it here it will add dxguid at link flags

My first sdl patch was adding missing guid needed by sdl in vo_sdl
but new versions may require additional guids.
I also stripped -ldxguid from sdl-config call.

There were some changes in configure that made this not work anymore

so I've modified the patch to first add ldxguid in the check
then removing it from _ld_tmp, that looked ugly for me

this patch instead make possible link with dxguid
but the problem is the discrepancy between mingw
libdxguid.a and mingw headers.

guids in vo_directx and vo_sdl are declared in mingw
so they can be safely removed.

the problem is tvi_dshow that defines many guids,
and two of them are not defined in headers but included
in libdxguid.a

I'm attaching the sdl patch before I was using this one.

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xx_sdl_static.diff
Type: text/x-diff
Size: 2578 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100117/d3c138e1/attachment.diff>