[MPlayer-dev-eng] [PATCH] Screen blanking prevention for Maemo

Siarhei Siamashka siarhei.siamashka at gmail.com
Thu Jan 14 15:57:36 CET 2010


On Sunday 20 December 2009, Jan Knutar wrote:
> This patch prevents the screen from switching off and the device
> entering lower power state on Maemo devices (Nokia Nxxx).
>
> The original code was most likely written at or around MPlayer 1.0rc1
> timeframe by Siarhei Siamashka, and lived in the maemo port of MPlayer
> (which is now effectively abandoned/obsolete). Whether it was ever
> submitted upstream I don't know.
>
> It was fished out of the old rc1 maemo mplayer by Sampo Savola, who
> added it to a new maemo "port" based on a recent-ish svn of MPlayer.
>
> I fished it out of his port and made it #ifdef'd maemo, patch against
> today's svn.
>
> Any issues with this living in upstream MPlayer?

Hi, maybe it's a good idea to address Diego's coding style comment, resubmit
an updated patch and see what happens next?

It would be also nice if you could try benchmarking the overhead of blanking 
prevention code with different settings for heartbeat period and provide some
numbers (probably using mplayer '-benchmark' combined with '-framedrop'
or '-hardframedrop' options when trying to watch some heavy video and measure
the number of dropped frames).

-- 
Best regards,
Siarhei Siamashka



More information about the MPlayer-dev-eng mailing list