[MPlayer-dev-eng] MPlayer [PATCH] RSound plugin, KISS network audio.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jan 10 15:42:48 CET 2010


On Sun, Jan 10, 2010 at 02:09:24PM +0100, Hans-Kristian Arntzen wrote:
> Network audio has bothered me for quite a while in Linux, and I have
> made a simplistic program that allows for using networked audio.

Why is everyone's solution to Linux sound issues to create even more of a mess?

> I have also made an audio driver for MPlayer that acts as an rsound
> client. Like, -ao rsound:host=<host>:port=<port>. It is in early
> development, but it might create some interest. Patch can be found
> here: http://maister.homelinux.org/downloads/rsound.patch

You'd have to give very good reasons why it is better than PulseAudio,
nas, mas and the hundreds of other failed (or in-progress) attempts
to generate any kind of enthusiasm I think.
And even though you haven't submitted it for review, here's a short one
anyway (since a certain distribution likes to apply patches without review).
Initializing global variables to 0 explicitly is pointless code,
and
static void drain()
is something else then
static void drain(void)
and it's highly unlikely you actually meant the former.
Using CLOCK_REALTIME will probably be quite some fun if the clock is ever
set manually.
I also suspect this has never been testes with server and client having
different endianness.
That is besides lacking proper configure checks for some of the features
it needs.



More information about the MPlayer-dev-eng mailing list