[MPlayer-dev-eng] [PATCH] VF Overlay

[Diego Biurrun]

On Sat, Feb 27, 2010 at 05:39:09PM -0500, Jason Tackaberry wrote:
> 
> Updated patch attached.  Changes since last submission by Ben:
> 
>      8. I did _not_ remove the input stubs from mencoder.c because the
>         suggested alternatives weren't feasible:
>               * Moving vf_overlay.c to SRCS-MPLAYER instead of
>                 SRCS-COMMON broke mencoder because vf_info_overlay is
>                 referenced in libmpcodecs/vf.c.  I could create a
>                 special vf_overlay-mencoder.c file that redeclares a
>                 dummy vf_info_overlay (because vf_overlay is not usable
>                 with mencoder anyway), but that's very kludgey.
>               * Including the necessary objects in mencoder quickly spun
>                 out of control, requiring input/input.c, input/lirc.c,
>                 input/appleir.c, mp_fifo.c, linking in lirc, not to
>                 mention the need to resolve newly introduced duplicated
>                 declarations (like mplayer_put_key).
> 
> Any suggestions for #2 or #8, or any further comments, suggestions, or
> flames?

What about a filter_list_mplayer[] or similar?  Could that work?

> --- libmpcodecs/vf.c	(revision 30759)
> +++ libmpcodecs/vf.c	(working copy)
> @@ -118,6 +118,9 @@
>  extern const vf_info_t vf_info_ow;
> +#ifdef HAVE_SHM
> +extern const vf_info_t vf_info_overlay;
> +#endif

#ifdefs around extern declarations are unnecessary.  I removed them a
long time ago, please don't undo my work :)

Diego