[MPlayer-dev-eng] [PATCH] CDDB support for OS/2

[KO Myung-Hun]

Hi/2.

Reimar Döffinger wrote:
> On Sun, Feb 21, 2010 at 12:08:15AM +0900, KO Myung-Hun wrote:
>> Reimar Döffinger wrote:
>>> On Fri, Feb 19, 2010 at 10:28:47PM +0900, KO Myung-Hun wrote:
>>>>>> @@ -340,7 +423,7 @@
>>>>>>   	sprintf( file_name, "%s%08lx", cddb_data->cache_dir, cddb_data->disc_id);
>>>>>>
>>>>>>   	file_fd = open(file_name, O_RDONLY
>>>>>> -#if defined(__MINGW32__) || defined(__CYGWIN__)
>>>>>> +#if defined(__MINGW32__) || defined(__CYGWIN__) || defined(__OS2__)
>>>>>>   	| O_BINARY
>>>>>>   #endif
>>>>>
>>>>> This looks like a candidate for a configure check.
>>>>
>>>> So do I. I'll try later such as HAVE_DOS_BINARY ? Hmm.. poor nameing sense.
>>>
>>> #ifndef O_BINARY
>>> #define O_BINARY 0
>>> #endif
>>> for example.
>>> Don't see why this should depend on the OS instead of whether O_BINARY exists.
>>
>> I also know this approach. But the reason why I hesitate to use this
>> is that BeOS also this flag but I'm not sure it has the same meaning
>> as Win32 and OS/2.
>>
>> Are you sure ?
>
> All information I can find says that BeOS only has O_BINARY for compatibility,
> it has no effect at all.
> So it sounds safe to me, at least good enough to try IMHO.

Ok, I'll try that.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr