[MPlayer-dev-eng] [PATCH] add WAVEFORMATEXTENSIBLE support to wav demuxer

[Reimar Döffinger]

On Sat, Feb 20, 2010 at 09:08:47PM -0500, Jason Tackaberry wrote:
> The attached patch updates the wav file demuxer to support retrieving
> the proper codec id from a WAVEFORMATEXTENSIBLE extension header if
> present.

Seems ok to me.

> I suppose demuxers for containers that support wave tracks, like mkv and
> ogg, should eventually be updated as well.  Not sure how common that is,
> however.

Ogg uses a different method of storing the information and should be fine already.
mkv could use a little update though.

> Index: demux_audio.c
> ===================================================================
> --- demux_audio.c	(revision 30668)
> +++ demux_audio.c	(working copy)
> @@ -416,6 +416,8 @@
>        }
>        stream_read(s,(char*)((char*)(w)+sizeof(WAVEFORMATEX)),w->cbSize);

Holy cow. I think I need to find some time to clean up that code.