[MPlayer-dev-eng] [PATCH] VCD support for OS/2

[KO Myung-Hun]

Diego Biurrun wrote:
> On Fri, Feb 19, 2010 at 10:26:26PM +0900, KO Myung-Hun wrote:
>> Diego Biurrun wrote:
>>> On Fri, Feb 19, 2010 at 12:23:32PM +0900, KO Myung-Hun wrote:
>>>>
>>>> This patch adds VCD support for OS/2.
>>>>
>>>> --- stream/stream_vcd.c	(revision 30605)
>>>> +++ stream/stream_vcd.c	(working copy)
>>>> @@ -22,6 +22,12 @@
>>>>
>>>> +#if defined(__OS2__)
>>>> +#define INCL_DOS
>>>> +#define INCL_DOSDEVIOCTL
>>>> +#include<os2.h>
>>>> +#endif
>>>
>>> Somehow this seems to be in every other patch you post.
>>> Maybe it could be in a more central place...
>>
>> At least, removed one from vcd_read_os2.h.
>
> I'm not sure this is the way to go.  A wild idea: Why not have a header
> (platform.h or similar) in some central place, like os_support.h in
> libavformat?  OS-specific hacks and #ifdefs could be hidden there...

I thought like you, and I agree with you. But the macros to include a 
proper contents of the same header(os2.h) are different depending on 
needed APIs.

Of course, it's possible to define all the macros. However, it's not 
adequate to the reason introducing those macros.

Nevertheless, if you prefer os_support.h-like method, I willing to do it.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr