[MPlayer-dev-eng] [PATCH] VCD support for OS/2

[KO Myung-Hun]

Diego Biurrun wrote:
> On Fri, Feb 19, 2010 at 12:23:32PM +0900, KO Myung-Hun wrote:
>>
>> This patch adds VCD support for OS/2.
>>
>> --- stream/vcd_read_os2.h	(revision 0)
>> +++ stream/vcd_read_os2.h	(revision 0)
>> @@ -0,0 +1,258 @@
>> +
>> +#ifndef MPLAYER_VCD_READ_OS2_H
>> +#define MPLAYER_VCD_READ_OS2_H
>> +
>> +#define INCL_DOS
>> +#define INCL_DOSDEVIOCTL
>> +#include<os2.h>
>> +
>> +#include "mp_msg.h"
>> +
>> +
>> +    if (rc) {
>> +        mp_msg(MSGT_STREAM, MSGL_ERR, "DosDevIOCtl(GETAUDIOTRACK) = 0x%lx\n", rc);
>> +
>> +        return -1;
>> +    }
>> +
>> +
>> +    if (rc) {
>> +        mp_msg(MSGT_OPEN, MSGL_ERR, "DosDevIOCtl(GETAUDIODISK) = 0x%lx\n", rc);
>> +
>> +        return NULL;
>> +    }
>> +
>> +            if (rc) {
>> +                mp_msg(MSGT_OPEN, MSGL_ERR, "DosDevIOCtl(GETAUDIOTRACK) = 0x%lx\n", rc);
>> +
>> +                return NULL;
>> +            }
>
> I would drop those empty lines in the if-blocks, same below.
>

Fixed.

>> +            mp_msg(MSGT_OPEN, MSGL_INFO, "track %02d:  adr=%d  ctrl=%d  %02d:%02d:%02d\n",
>> +                   i,
>> +                   sDataTrack.bControlInfo&  0x0F,
>> +                   sDataTrack.bControlInfo>>  4,
>> +                   sDataTrack.msfStart.bMinute,
>> +                   sDataTrack.msfStart.bSecond,
>> +                   sDataTrack.msfStart.bFrame);
>> +        }
>> +        else
>
> } else
>

Fixed.

>> --- stream/stream_vcd.c	(revision 30605)
>> +++ stream/stream_vcd.c	(working copy)
>> @@ -22,6 +22,12 @@
>>   #include<windows.h>
>>   #endif
>>
>> +#if defined(__OS2__)
>> +#define INCL_DOS
>> +#define INCL_DOSDEVIOCTL
>> +#include<os2.h>
>> +#endif
>
> Somehow this seems to be in every other patch you post.
> Maybe it could be in a more central place...

At least, removed one from vcd_read_os2.h.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vcdos2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100219/8e11322b/attachment.txt>