[MPlayer-dev-eng] [PATCH] allow make -r to work

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 16 23:26:43 CET 2010


On Tue, Feb 16, 2010 at 11:19:01PM +0100, Gianluigi Tiesi wrote:
> On Tue, Feb 16, 2010 at 07:01:39PM +0100, Reimar D?ffinger wrote:
> > On Tue, Feb 16, 2010 at 02:17:24PM +0100, Diego Biurrun wrote:
> > > On Mon, Feb 15, 2010 at 11:01:20PM +0100, Reimar D?ffinger wrote:
> > > > we currently rely on several implicit rules, so make -r actually does
> > > > not compile at all.
> > > 
> > > Yes, I designed it that way on purpose.  What is the problem with that?
> > > Or to rephrase my question: Why do you want to use 'make -r' in the
> > > first place?
> > 
> > Because MPlayer doesn't build. Again. And due to the .rc file.
> > And make -r is a simple fix, and simply removes a huge load of dependencies,
> > probably speeding up compilation on MinGW/Cygwin and (probably) making
> > it a whole lot less brittle.
> 
> mingw/cygwin build is slowed a lot by the non cow fork, anyway make
> slows down too, but I suspect there is no way to force make -r
> simply calling make with some variable set in the makefile
> right?

It's not the same thing, but you can test this:
Index: Makefile
===================================================================
--- Makefile	(revision 30603)
+++ Makefile	(working copy)
@@ -21,6 +21,7 @@
 
 include config.mak
 
+.SUFFIXES:
 
 ###### variable declarations #######
 
@@ -836,6 +837,15 @@
 %.ho: %.h
 	$(CC) $(CFLAGS) -Wno-unused -c -o $@ -x c $<
 
+%.o: %.S
+	$(CC) $(ASFLAGS) -c -o $@ $<
+
+%.o: %.c
+	$(CC) $(CFLAGS) -c -o $@ $<
+
+%.o: %.cpp
+	$(CC) $(CXXFLAGS) -c -o $@ $<
+
 %.o: %.m
 	$(CC) $(CFLAGS) -c -o $@ $<
 
Index: common.mak
===================================================================
--- common.mak	(revision 30603)
+++ common.mak	(working copy)
@@ -4,6 +4,8 @@
 
 all: # make "all" default target
 
+.SUFFIXES:
+
 ifndef SUBDIR
 vpath %.c   $(SRC_DIR)
 vpath %.h   $(SRC_DIR)



More information about the MPlayer-dev-eng mailing list