[MPlayer-dev-eng] [PATCH] Add -va for video acceleration

[Gwenole Beauchesne]

Le 16 févr. 10 à 19:06, Uoti Urpala a écrit :

>> I really don't want to duplicate videocodec entries since this is
>> error-prone. see e.g. VDPAU, the fourcc lines now deviate a little.  
>> This
>> could be worse when there will be 4 hwaccels to maintain...
>
> I think the best way to address this would be extend codecs.conf  
> syntax
> somehow to avoid the duplication.

That's my "hwaccel" attribute suggestion.

e.g. we have
videocodec ffmpeg12
...
hwaccel vaapi
hwaccel vdpau

this would generate valid ffmpeg12{,vaapi,vdpau}. We can also have a  
"long_name" version in the hwaccel map table to extend the name.  
"FFmpeg MPEG-1/2 decoder (with HWACCEL)"

>> OTOH, I quite don't mind duplicating and stick to the current  
>> approach
>> which is -vo VO -vc ffmpeg12ACCEL,ffodivxACCEL,
>
> Hmm this seems to contradict what you said just before?

No, this is only my least preferred solution, if I don't care of  
users. I wanted an approach that would help users specify the desired  
accelerator, and not typing the whole codecs on a single line. Of  
course, they could add that to their default config, but they wouldn't  
know by default.

> This is basically my preferred approach; but I think it's worth
> polishing the details somewhat (allow sharing the codecs.conf fourcc
> lines somehow, add syntax for the user to specify "all VDPAU codecs"
> without listing them one by one if he doesn't want to differentiate).

Yes, the "all HWACCEL codecs" part is also desirable because e.g. -vc  
ffmpeg12crystalhd,ffodivxcrystalhd,ffh264crystalhd,ffvc1crystalhd  
would be terribly tedious to type, and somehow error-prone.