[MPlayer-dev-eng] [PATCH] allow make -r to work

[Reimar Döffinger]

On Tue, Feb 16, 2010 at 02:20:08PM +0100, Diego Biurrun wrote:
> On Tue, Feb 16, 2010 at 03:35:33AM +0100, Gianluigi Tiesi wrote:
> > On Mon, Feb 15, 2010 at 11:01:20PM +0100, Reimar D?ffinger wrote:
> > > we currently rely on several implicit rules, so make -r actually does
> > > not compile at all.
> > > Patch below fixes the cases I know of, any objections?
> > > Index: Makefile
> > > ===================================================================
> > > --- Makefile	(revision 30589)
> > > +++ Makefile	(working copy)
> > > @@ -836,6 +836,15 @@
> > >  %.ho: %.h
> > >  	$(CC) $(CFLAGS) -Wno-unused -c -o $@ -x c $<
> > >  
> > > +%.o: %.S
> > > +	$(CC) $(ASFLAGS) -c -o $@ $<
> > > +
> > > +%.o: %.c
> > > +	$(CC) $(CFLAGS) -c -o $@ $<
> > > +
> > > +%.o: %.cpp
> > > +	$(CC) $(CXXFLAGS) -c -o $@ $<
> > > +
> > >  %.o: %.m
> > >  	$(CC) $(CFLAGS) -c -o $@ $<
> > >  
> > 
> > I still have problems on msys with the -rc.o rule
> > %-rc.o: %.rc
> >     $(WINDRES) -I. $< $@
> > 
> > 
> > gcc osdep/mplayer.rc.o   -o osdep/mplayer.rc
> > gcc.exe: osdep/mplayer.rc.o: No such file or directory
> > gcc.exe: no input files
> > make: *** [osdep/mplayer.rc] Error 1
> 
> Is that with HEAD or with Reimar's patch applied?  What happens if you
> move the .rc rule up (to line 864) in the Makefile?

Huh? 864 is down from the current location?!
Either way I moved it both up (directly below all) and down (directly before
configure) and neither makes any difference.

This is the debug output of make:
    Considering target file `osdep/mplayer-rc.o'.
     File `osdep/mplayer-rc.o' does not exist.
     Looking for an implicit rule for `osdep/mplayer-rc.o'.
     Trying pattern rule with stem `mplayer-rc'.
     Trying implicit prerequisite `osdep/mplayer-rc.m'.
     Trying pattern rule with stem `mplayer'.
     Trying implicit prerequisite `osdep/mplayer.rc'.
     Found an implicit rule for `osdep/mplayer-rc.o'.
      Considering target file `osdep/mplayer.rc'.
       Looking for an implicit rule for `osdep/mplayer.rc'.
       Trying pattern rule with stem `mplayer.rc'.
       Trying implicit prerequisite `osdep/mplayer.rc.o'.
       Found an implicit rule for `osdep/mplayer.rc'.
        Considering target file `osdep/mplayer.rc.o'.
         File `osdep/mplayer.rc.o' does not exist.
         Looking for an implicit rule for `osdep/mplayer.rc.o'.
...
...
         No implicit rule found for `osdep/mplayer.rc.o'.
          Pruning file `version.h'.
         Finished prerequisites of target file `osdep/mplayer.rc.o'.
        Must remake target `osdep/mplayer.rc.o'.
        Successfully remade target file `osdep/mplayer.rc.o'.
       Finished prerequisites of target file `osdep/mplayer.rc'.
       Prerequisite `osdep/mplayer.rc.o' of target `osdep/mplayer.rc' does not exist.
      Must remake target `osdep/mplayer.rc'.
i586-mingw32-gcc   osdep/mplayer.rc.o   -o osdep/mplayer.rc