[MPlayer-dev-eng] [PATCH] Add -va for video acceleration

[Gwenole Beauchesne]

On Tue, 16 Feb 2010, Uoti Urpala wrote:

> On Tue, 2010-02-16 at 16:33 +0100, Gwenole Beauchesne wrote:
>> On Tue, 16 Feb 2010, Uoti Urpala wrote:
>>> I think the existing -vfm option would suit this use too (preferring
>>> codecs using a particular kind of hardware decoding).
>>
>> How? They all depend on FFmpeg. Or do you want to split them all as -vfm
>> ffmpeg,ffmpeg_vaapi,ffmpeg_crystalhd? It's not really user-friendly.
>
> Either add support for having one codec in multiple categories for the
> -vfm option, or just split the 'ffmpeg' one into 'ffmpeg' (FFmpeg
> software decoders) and 'vdpau', 'vaapi' etc - I can't at least
> immediately think of any important problems with that.

I think the problems with this approach are:

(1) We will tend to duplicate videocodec entries since this would require 
different "driver" lines, isn't it? So far, my current approach works by 
just adding e.g. out VAAPI_MPEG2 to an existing videocodec entry. It's 
preferable to add a single line rather than copying the whole entry x N 
accelerators (N can be 4 very easily).

(2) This probably would require more changes to vd_ffmpeg.c since new 
vd_info and LIBVD_EXTERN(xxx) would be needed + a means to pass the 
selected video accelerator to the init function.