[MPlayer-dev-eng] [PATCH] -vobsub support for mencoder

[compn]

On Wed, 10 Feb 2010 23:30:48 +0200, Uoti Urpala wrote:
>On Wed, 2010-02-10 at 14:57 -0500, compn wrote:
>> On Wed, 10 Feb 2010 17:37:08 +0100, Gianluigi Tiesi wrote:
>> >On Wed, Feb 10, 2010 at 06:43:13AM +0200, Uoti Urpala wrote:
>> and if mencoder is unmaintained and no one cares about it, then i say
>> apply these patches forthwith! end end these endless discussions about
>> killing mencoder. lets see you rm -rf it in git first!
>
>I wonder if you maybe misunderstood my main objection to such changes.

yes, brevity is the soul of wit.

>Trying to make MPlayer and MEncoder share more code without a massive
>cleanup of MEncoder is a bad idea because it ties MPlayer more closely
>to the unmaintained MEncoder. Sharing code is bad in this case because
>it means changing the code then either breaks MEncoder or requires
>altering it (making such changes harder). Even changes that could be
>described as "reducing code duplication", which is usually a positive
>thing, are bad when one side is a mess (and bad enough that such changes
>aren't really even a small step towards fixing it). MEncoder is a mess,
>and would require much more than such changes to stop being a mess. As
>long as the codebase is as separate as possible it's at least a mess
>that can be mostly ignored when working on anything else.

thems a lots of words for saying 'abandon mencoder all yee who enter
here'.

are you saying that the vobsub code should just be duplicated (as in
the original vobsub patch) ? or that mencoder should be abandoned?
please be clear and use as less words as possible.

-compn