[MPlayer-dev-eng] [PATCH] Win32 loader support for OS/2

[Diego Biurrun]

On Wed, Feb 10, 2010 at 06:38:29PM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Wed, Feb 10, 2010 at 12:35:07AM +0900, KO Myung-Hun wrote:
>>>
>>> Diego Biurrun wrote:
>>>> On Tue, Feb 09, 2010 at 11:12:06PM +0900, KO Myung-Hun wrote:
>>>>>
>>>>> Reimar Döffinger wrote:
>>>>>> On Fri, Feb 05, 2010 at 08:53:25PM +0900, KO Myung-Hun wrote:
>>>>>>> This patch adds Win32 loader support for OS/2.
>>>>>>
>>>>>>> +#ifdef DEBUG_QTX_API
>>>>>>> +    printf("addr = %p, cb = %d, fl = %08X : ", p, cb, fl);
>>>>>>> +    if(fl&    0x10)
>>>>>>> +        printf("COMMIT ");
>>>>>>> +    if(fl&    0x2000 )
>>>>>>> +        printf("SHARED ");
>>>>>>> +    if(fl&    0x4000)
>>>>>>> +        printf("FREE ");
>>>>>>> +    if(fl&    0x10000)
>>>>>>> +        printf("BASE ");
>>>>>>> +    if(fl&    0x01)
>>>>>>> +        printf("READ ");
>>>>>>> +    if(fl&    0x02)
>>>>>>> +        printf("WRITE ");
>>>>>>> +    if(fl&    0x04)
>>>>>>> +        printf("EXEC ");
>>>>>>> +    if(fl&    0x08)
>>>>>>> +        printf("GUARD ");
>>>>>>> +    printf("\n");
>>>>>>> +#endif
>>>>>>
>>>>>> is that necessary?
>>>>>
>>>>> Of course for debugging.
>>>>
>>>> Probably you should just drop that hunk then.
>>>
>>> Would you mind explaining the reason ?
>>
>> Because it is only useful for debugging?
>
> Ok even though I don't agree with you.

I don't think special-purpose debugging code should be kept,
regardless of platform, be it Linux, Windows or OS/2.  We have
enough cruft as is and should avoid adding more.

Diego