[MPlayer-dev-eng] [PATCH] -vobsub support for mencoder

Gianluigi Tiesi mplayer at netfarm.it
Wed Feb 10 04:56:37 CET 2010


Hi,

I'm working on moving some of mplayer subtitle code in mpcommon
and make mencoder use it.

The attached patch should not be considered as final
but I would to post to have some feedbacks / corrections

Yes a better way would be vf_vobsub.c, it looks not trivial
to reuse the current vobsub code (I'm not so expert in frame processing tough)

The code looks working but I see some glitches at the first sub
the job is not easy since the code is full of globals

just a note:
init_vo_spudec()
and
open_vobsub()

are declared in mp_core.h instead of mpcommon.h
even if functions body are in mpcommon.c
this avoid inclusion of mp_core.h in mpcommon.h
(command.c will complain about some stuff not defined)
but feel free to move away

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xx_vobsub_mencoder.diff
Type: text/x-diff
Size: 29012 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100210/9eba9e91/attachment.diff>


More information about the MPlayer-dev-eng mailing list