[MPlayer-dev-eng] [PATCH] Win32 loader support for OS/2

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Fri, Feb 05, 2010 at 08:53:25PM +0900, KO Myung-Hun wrote:
>>
>> This patch adds Win32 loader support for OS/2.
>>
>> --- loader/ldt_keeper.c	(revision 30512)
>> +++ loader/ldt_keeper.c	(working copy)
>> @@ -281,6 +281,11 @@
>>       }
>>   #endif
>>
>> +#ifdef __OS2__
>
> #elif defined(__OS2__)
>

Ok.

>> --- loader/module.c	(revision 30512)
>> +++ loader/module.c	(working copy)
>> @@ -744,6 +744,50 @@
>>
>>   #ifdef EMU_QTX_API
>>
>> +#ifdef __OS2__
>> +uint32_t _System DosQueryMem(void *, uint32_t *, uint32_t *);
>
> Aren't you simply missing a header #include?
>

It causes type clash between OS/2 and wine.

>> +static int is_invalid_ptr(void *p)
>> +{
>> +    uint32_t cb = 1;
>> +    uint32_t fl;
>> +
>> +    if( DosQueryMem(p,&cb,&fl))
>
> if(
>
> I know the loader code is exceedingly ugly, but let's not make
> it worse :)
>
>> +    // Occasionally, ptr with 'EXEC' attr is passed.
>> +    // On OS/2, however, malloc() never set 'EXEC' attr.
>
> sets
>

Fixed.

> If Reimar has no more comments, I think you can commit with these
> changes applied.
>

Ok. ^^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: loader.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100208/0f4d9536/attachment.asc>