[MPlayer-dev-eng] [PATCH] prefix EXTERN_ASM to global variables in wrapper.S

[KO Myung-Hun]

Hi/2.

Reimar Döffinger wrote:
> On Fri, Feb 05, 2010 at 08:24:17PM +0900, KO Myung-Hun wrote:
>> KO Myung-Hun wrote:
>>> Diego Biurrun wrote:
>>>> On Thu, Feb 04, 2010 at 03:03:56PM +0900, KO Myung-Hun wrote:
>>>>>
>>>>> --- loader/wrapper.S (revision 30495)
>>>>> +++ loader/wrapper.S (working copy)
>>>>> @@ -1,27 +1,33 @@
>>>>> -.section .data
>>>>> -.globl caller_return
>>>>> -caller_return:
>>>>> +#include "config.h"
>>>>> +
>>>>> +#define GLUE(a, b) a ## b
>>>>> +#define JOIN(a, b) GLUE(a, b)
>>>>> +#define X(s) JOIN(EXTERN_ASM, s)
>>>>
>>>> I think X is a very poor macro name.
>>>>
>>>
>>> How about MANGLE ? ^^
>>>
>>
>> Applied in two parts,
>>
>>      1. removal of .section
>>      2. prefix EXTERN_ASM
>
> Thank you. And at some point we should probably have said "welcome as a developer".
> Also feel free to add yourself as a maintainer in DOCS/tech/MAINTAINERS
> if you want to be considered the official maintainer for something
> (not that it makes much of a difference in practice).

Thanks for your welcome and the information. ^________^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr