[MPlayer-dev-eng] [PATCH] prefix EXTERN_ASM to global variables in wrapper.S

KO Myung-Hun komh at chollian.net
Fri Feb 5 12:24:17 CET 2010


Hi/2.

KO Myung-Hun wrote:
> Hi/2.
>
> Diego Biurrun wrote:
>> On Thu, Feb 04, 2010 at 03:03:56PM +0900, KO Myung-Hun wrote:
>>>
>>> --- loader/wrapper.S (revision 30495)
>>> +++ loader/wrapper.S (working copy)
>>> @@ -1,27 +1,33 @@
>>> -.section .data
>>> -.globl caller_return
>>> -caller_return:
>>> +#include "config.h"
>>> +
>>> +#define GLUE(a, b) a ## b
>>> +#define JOIN(a, b) GLUE(a, b)
>>> +#define X(s) JOIN(EXTERN_ASM, s)
>>
>> I think X is a very poor macro name.
>>
>
> How about MANGLE ? ^^
>

Applied in two parts,

     1. removal of .section
     2. prefix EXTERN_ASM

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr




More information about the MPlayer-dev-eng mailing list