[MPlayer-dev-eng] [patch] loading libass subtitles from network

[Grigori Goronzy]

On 02/04/2010 08:45 PM, Reimar Döffinger wrote:
> Looks good to me, any objections?
>

I think the patch is fine.
I'm not sure about the size limit anymore. It was supposed to be a
safeguard to protect users from accidentally passing very big files into
libass, I assume. OTOH arbitrary limits like 10 MB (or 50 MB in libass
git for ass_read_file) aren't nice. ASS scripts can get quite big for
advanced karaoke and fonts and even bitmaps can be included in the
script, which means even 50 MB might not be enough. I'll probably
completely remove the size limit in libass.

I'd recommend that the size limit in this change should at least be
increased to 50 or 100 MB for better compatibility.

Grigori