[MPlayer-dev-eng] [PATCH] prefix EXTERN_ASM to global variables in wrapper.S

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Fri, Feb 05, 2010 at 12:39:57AM +0900, KO Myung-Hun wrote:
>>
>> Diego Biurrun wrote:
>>> On Thu, Feb 04, 2010 at 03:03:56PM +0900, KO Myung-Hun wrote:
>> --- loader/wrapper.S	(revision 30502)
>> +++ loader/wrapper.S	(working copy)
>> @@ -1,27 +1,33 @@
>> -.section .data
>> -.globl caller_return
>> -caller_return:
>> +#include "config.h"
>> +
>> +#define GLUE(a, b) a ## b
>> +#define JOIN(a, b) GLUE(a, b)
>> +#define MANGLE(s)  JOIN(EXTERN_ASM, s)
>
> Unless I'm completely daft, the JOIN macro is just a transparent
> wrapper around the GLUE macro.  Plus, the GLUE macro could be
> directly incorporated into the MANGLE macro.
>

I thought like you at first, but without them, EXTERN_ASM is not 
translated to '_'. For examples, MANGLE(caller_return) is translated to 
'EXTERN_ASMcaller_return'.

I found this trick in libavcodec\arm\asm.S


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66 GHz with 1 GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr