[MPlayer-dev-eng] [patch] loading libass subtitles from network
uoti.urpala at pp1.inet.fi
Thu Feb 4 01:17:31 CET 2010
On Thu, 2010-02-04 at 01:24 +0300, Yuriy Kaminskiy wrote:
> Currently libass doesn't use mplayer stream infrastructure, and fails to load
> subtitles from network.
> This patch fixes that.
Please send patches for libass improvements against the git repo. libass
support in svn is not actively maintained any more, and parts of your
patch are outdated for the current code (like the 10 MiB limit).
Like Reimar said, the "#ifdef CONFIG_NETWORK" looks pointless - is there
any reason not to use the stream_read() based code regardless of network
Doing realloc() in steps of STREAM_BUFFER_SIZE (2048) bytes is
inefficient - the size limit was raised from 10 MiB because there are
files larger than that, over 5000 times your step size.
More information about the MPlayer-dev-eng