[MPlayer-dev-eng] [PATCH] fix for crt8 init dll

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 2 20:16:36 CET 2010


On Tue, Feb 02, 2010 at 12:16:30AM +0100, Gianluigi Tiesi wrote:
> msvcrt static linked dll and newer are making a check for "mixed crt" (posix)
> executables, this implies a GetModuleHandle on the main exe
> and a check for a section named .mixcrt
> 
> The attached patch fixes it by providing a minimal struct
> needed to the crt init function, and fakes the section
> .mixcrt so the crt avoid using Encode/Decode Pointers

Could you also explain why you want that? :-)
Is there some broken codec that ends up using the static
linked MSVCRT for half the encode/decode and our stubs
for the other half or something like that (how would that
happen?)?

>      if(!name)
> -#ifdef QTX
> -	result=1;
> -#else
> -	result=0;
> -#endif
> +	result=(HMODULE)&mp_exe.doshdr;

While it might just be stupid code, I'd assume this will probably
break at least some other decoder.
Well, on reading the commit log for those it's likely to be fine,
I'm just a bit paranoid about the loader code...



More information about the MPlayer-dev-eng mailing list