[MPlayer-dev-eng] [PATCH] addrinfo check

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Feb 1 21:30:13 CET 2010


On Mon, Feb 01, 2010 at 10:02:18PM +0200, Uoti Urpala wrote:
> On Mon, 2010-02-01 at 20:40 +0100, Reimar Döffinger wrote:
> > On Mon, Feb 01, 2010 at 11:20:34PM +0900, KO Myung-Hun wrote:
> > > Declaration of pointer to struct always succeeds.
> > 
> > See:
> > r30324 | reimar | 2010-01-16 17:22:57 +0100 (Sat, 16 Jan 2010) | 3 lines
> > 
> > Fix struct addrinfo check, its definition might not allow actually allocating it.
> > Fixes MinGW64 compilation.
> > 
> > Your version will break MinGW64.
> > What is the exact compilation error you get?
> 
> Whatever the particular error he gets, your test is nonsense.
> "struct does_not_exist *p;" will happily compile without warnings. In
> other words the test does not provide any information beyond the ability
> to #include the headers at all.

Thanks for repeating what he said in one line in 4 lines.
I can actually read myself, however knowing the exact error
saves me a lot of time in tracking down what's broken in MinGW64.



More information about the MPlayer-dev-eng mailing list