[MPlayer-dev-eng] [RFC] rgb2rgb global function pointers

Diego Biurrun diego at biurrun.de
Tue Aug 31 14:13:35 CEST 2010


On Fri, Aug 27, 2010 at 12:06:34PM -0300, Ramiro Polla wrote:
> 
> These are the places that are still using those functions directly:
> ./gui/wm/ws.c:314:     wsConvFunc=rgb32tobgr32;
> ./gui/wm/ws.c:322:     wsConvFunc=rgb32tobgr24;
> ./gui/wm/ws.c:326:     wsConvFunc=rgb32to16;
> ./gui/wm/ws.c:330:     wsConvFunc=rgb32tobgr16;
> ./gui/wm/ws.c:334:     wsConvFunc=rgb32to15;
> ./gui/wm/ws.c:338:     wsConvFunc=rgb32tobgr15;
> ./gui/win32/skinload.c:167:      rgb32tobgr32(bmp.Image, bmp.Image, bmp.ImageSize);
> ./gui/win32/skinload.c:168:      if(skin->desktopbpp == 16) rgb32tobgr15(bmp.Image, bf->data, bmp.ImageSize);
> ./gui/win32/skinload.c:169:      else if(skin->desktopbpp == 24) rgb32tobgr24(bmp.Image, bf->data, bmp.ImageSize);
> ./libvo/mga_template.c:84:	interleaveBytes(image[1],image[2],dest,
> 
> Comments, opinions, thoughts...?

I don't think it's worth spending much time on this.  Just drop that
feature from vo_mga and delete the GUI finally.

Diego


More information about the MPlayer-dev-eng mailing list