[MPlayer-dev-eng] [PATCH] unified timing patch for H264

Pásztor Szilárd bartosteka at freemail.hu
Sun Aug 29 12:54:10 CEST 2010


Dan Oscarsson:
> What files have this type of wrong PTS values?
> 
> The only files I have with video PTS out or order are som DVB-t
> mpegts files with h.264 in. To get that right I enabled the reorder
> code in dec_video instead. The pts values are correct but in wrong
> order.

We're talking about the same thing. All my PAFF H264 streams with
B-frames have PTS in wrong order. And that's enough for the A-V
sync algorithm because it sees jumping video timing all the time and
tries to correct, making video jerky. Turn on OSD and see how even
the clock is jerky at second changes because of wrong PTS order.

> I am not sure it is good to require avsync_found for fixing video
> pts. It would be better if video pts values are independent of
> audio pts values. I have code that sync audio and video in a
> different way and that will probably not work well with your code.

It will work exactly the same as before if it can't find A-V sync.
Then PTS simply won't get recalculated and that's it. Please test
the patch on your samples and report if anything goes wrong. This
"requiring a-v sync" is only a restriction for the new code to be
enabled, it points towards "do no harm if not sure".
See the danish_dvb.ts sample (reported on the users list) and see
how the new code finds frame exact A-V sync both with -correct-pts
and -nocorrect-pts.


More information about the MPlayer-dev-eng mailing list