[MPlayer-dev-eng] [PATCH] Automatic downmix

[ubitux]

On Sat, Aug 14, 2010 at 09:55:47PM +0200, ubitux wrote:
> On Tue, Aug 10, 2010 at 10:20:24PM +0200, Grigori Goronzy wrote:
> > Given the coefficients you pass to the pan filter, that's expected. :)
> > They sum up to 2.5 for each channel, ideally they should sum up to 1.
> > However I am not sure how volume will suffer if they're scaled down to
> > achieve that.
> 
> Oh I see. Well then here is a new patch with coefficients that sum up to
> 1.0. The volume is indeed reduced, but no more saturation.
> 
> Also, I note that the channels assignements was wrong if I followed the
> FLAC specs (are they wrong or is there a convertion somewhere?). So I used
> those two samples in order to get the right assignement:
> 
>   http://www-mmsp.ece.mcgill.ca/documents/audioformats/wave/Samples/Microsoft/6_Channel_ID.wav
>   http://www-mmsp.ece.mcgill.ca/documents/audioformats/wave/Samples/Microsoft/8_Channel_ID.wav
> 
> It also seems it's the right assignment for FLAC; I got the right sound
> for all my videos with Flac 5.1.
> 
> I think the patch is good now, so could I have a review of it?
> 
> Regards,
> 


Ping?

Nicolas, is it fine with you or you want to get them tuned a little
according to your last mail?

-- 
ubitux