[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Pásztor Szilárd]

Reimar Döffinger:
> If you can wait if we can come up with some nice improvements
> to libavcodec that would be better I think.

Yes, I'm looking forward to finding a suitable solution in lavc,
now that the discussion has been started. Your suggestion to add
a flags field seems ok to me as it is a general solution for many
purposes and optional to use. What Michael Niedermayer suggested
about the repeat_pict field is not what is needed here I think.

>> +static const mp_image_t mpi_first_field =
>> +{
>> +       type: MP_IMGTYPE_NULL
>> +};
> even if that is valid syntax, MPlayer uses the
>  .type = MP_IMGTYPE_NULL
> one everywhere else.

The type: xx syntax is gcc specific and the two forms are
equivalent, so I changed it to conform the rest of the code.

Alexander Strange:
> I have the first, but not the second, and I'm not sure if
> you need that. In either case, you can generate them with
> mencoder+xvid by setting frame_drop_ratio very high.

Thanks for the samples, I'll try them. But if the ongoing lavc
issue can be solved, no such samples will be in peril of getting
accidentally broken. I'm not fond of spreading codec-specific
checks all over the code if a general solution is possible.

One more thing: why does the lavf demuxer recognize (for example)
the m2hd.ts sample as 50fps? That's one ugly way of having
correct playback speed by halving the framerate and it won't work
once full-frame packets come (which they do). Adding a new bug to
counter the first bug is not solving the problem.