[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Reimar Döffinger]

On Sat, Aug 21, 2010 at 05:09:16PM +0200, Pásztor Szilárd wrote:
> Here is the latest version, with everything corrected, except this one:
> 
> Reimar Döffinger:
> > >  	if (decoded_frame) {
> > > +	    was_frame = 1;
> > >  	    update_subtitles(sh_video, sh_video->pts, mpctx->d_sub, 0);
> > >  	    update_teletext(sh_video, mpctx->demuxer, 0);
> > >  	    update_osd_msg();
> > >  	    current_module = "filter video";
> > >  	    if (filter_video(sh_video, decoded_frame, sh_video->pts))
> > >  		break;
> > > -	} else if (drop_frame)
> > > +	} else if (was_frame && drop_frame) // disable framedropping at
> > > the very first frame
> > 
> > This doesn't make any sense at all to me.
> > You can't just continue processing when decoded_frame is NULL.
> 
> ...because I don't see a problem here.

Well, not the problem I described, but if you want to disable frame
dropping, drop_frame would have to be set differently, not things changed
afterwards.
So at least the comment does not match the code.