[MPlayer-dev-eng] [RFC] libavutil/x86_cpu.h

[Diego Biurrun]

On Thu, Aug 12, 2010 at 06:15:55PM +0200, Reimar Döffinger wrote:
> On Tue, Aug 10, 2010 at 01:29:44PM +0200, Diego Biurrun wrote:
> > svn checkout --ignore-externals
> > 
> > is a configuration that we should make an effort to support.  It is a
> > useful and sensible thing to do, Nico works that way and I would like
> > to do it as well.  It really does marvels to compilation speed.
> > 
> > Nico kept complaining to me that you undermined all his efforts to
> > have MPlayer work without embedded FFmpeg and I promised to help
> > improve the situation :)
> 
> Okay, let's try something else.
> I still think it's an ugly hack either because of everyone being too
> lazy to at least try to export what is possible of x86_cpu.h, but
> how about a
> mpx86.h
> file that depending on LIBAVUTIL_A includes either libavutil/x86_cpu.h
> or a "copy" of that file?
> Then everyone will be bother with the issues their preferred solution
> has.

I don't think this is an improvement.  We still have the same code
duplication, if you can call it that, and the same maintenance burden.
I see no advantage to this approach.

Diego