[MPlayer-dev-eng] [PATCH] Fix AC3 passthrough on Intel Macs

[Sean McGovern]

As requested, here is the patch *sans*-compiler warning fixups.

On Mon, Aug 16, 2010 at 8:33 AM, Sean McGovern <gseanmcg at gmail.com> wrote:

> OK, I will re-send the patch later today.
> -----Original Message-----
> From: compn <tempn at twmi.rr.com>
> Sender: mplayer-dev-eng-bounces at mplayerhq.hu
> Date: Mon, 16 Aug 2010 00:06:58
> To: <mplayer-dev-eng at mplayerhq.hu>
> Reply-To: mplayer-dev-eng at mplayerhq.hu
> Subject: Re: [MPlayer-dev-eng] [PATCH] Fix AC3 passthrough on Intel Macs
>
> On Sun, 15 Aug 2010 14:54:19 -0400, Sean McGovern wrote:
> >
> >As I mentioned previously I have been looking into the AC3 passthrough
> >problem on Intel Macs and have made a patch to fix the issue. Also
> included
> >the changes from the previous patch that squelches some compiler warnings.
> >
> >Comments, suggestions, constructive criticisms welcome.
> >
> >Thanks in advance,
> >Sean McGovern
> >
> >
> >[ao_coreaudio-mactel.diff  application/octet-stream (5.4KB)]
> >Index: libao2/ao_coreaudio.c
> >-static OSStatus theRenderProc(void *inRefCon,
> >-                              AudioUnitRenderActionFlags *inActionFlags,
> >-                              const AudioTimeStamp *inTimeStamp,
> >-                              UInt32 inBusNumber, UInt32 inNumFrames,
> >+static OSStatus theRenderProc(__unused void *inRefCon,
> >+                              __unused AudioUnitRenderActionFlags
> *inActionFlags,
> >+                              __unused const AudioTimeStamp *inTimeStamp,
> >+                              __unused UInt32 inBusNumber, UInt32
> inNumFrames,
>
> if the patch without the compiler warnings is smaller, you should undo
> that patch. this __unused stuff looks terrible and makes the patch
> harder to read.
>
> -compn
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao_coreaudio-mactel-ac3_passthrough.diff
Type: application/octet-stream
Size: 1152 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100816/b10a7791/attachment-0001.obj>