[MPlayer-dev-eng] [PATCH] EOSD/ASS code factorization

[Nicolas George]

Le septidi 27 thermidor, an CCXVIII, Reimar Döffinger a écrit :
> The break is now pointless.

Indeed.

> Could you put the declaration before any statement?

Of course.

> Also here and in the other place
> mp_eosd_res_t res = {0};
> should be a nicer way to initialize.

I like it better, but I avoided it because gcc gives the silly warning
"missing initializer". Changed.

> Apart from that I haven't really looked in detail,
> so I don't know if it's actually going to have much of
> an advantage, but it's fine for me if you think it helps
> for the next steps (in terms of code simplification it
> doesn't seem like much of an improvement).

Thanks. I'll assume/hope it will be applied soon, and try to submit the next
step (dynamically adding EOSD objects) soon.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-factor-20100814c.diff
Type: text/x-diff
Size: 10934 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/05125c33/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100814/05125c33/attachment.pgp>