[MPlayer-dev-eng] [patch] backports/fixes from uoti demux_mkv.c for comp_algo==3

[Yuriy Kaminskiy]

Aurelien Jacobs wrote:
> On Thu, Aug 12, 2010 at 09:33:40PM +0400, Yuriy Kaminskiy wrote:
>> Minimal series:
>> min.01) Support comp_algo==3;
> 
> Why ? What is your reason to use the old unmaintained demux_mkv.c ?

Because it works better for me? (And I never hit unsupported features; even this
patch was for friend)

> Do you plan to send more patches to actually bring demux_mkv.c to the
> same level of feature than demux_lavf ?

When/if I'll meet other file with unsupported feature/bug - maybe. Especially
when most work already done by someone else. It would be certainly easier, than
bringing -demuxer lavf to same level as -demuxer mov/mkv.

>> That, unfortunately, is more an argument for disabling
>> the native demuxer than for the patch...
> 
> The fact that it is not used by default should be good enough IMHO, but
> if you want to totally disable it, feel free. It indeed contains many
> potential security issues.

[shrug] okey, I learned: good deed should not be left unpunished.

PS By the way, I quickly looked at lavf matroska demuxer, EXACTLY SAME integer
overflow problems present there... I think totally disabling demux_lavf.c is way
better solution.