[MPlayer-dev-eng] [PATCH] --enable-system-ffmpeg, was: linking external ffmpeg libs

[Reinhard Tartler]

On Fri, Aug 13, 2010 at 12:40:42 (CEST), Diego Biurrun wrote:

> On Thu, Aug 12, 2010 at 08:52:47AM -0400, Reinhard Tartler wrote:
>> On Thu, Aug 12, 2010 at 07:59:40 (EDT), Diego Biurrun wrote:
>> 
>> > On Wed, Aug 11, 2010 at 09:34:39PM +0100, Edd Barrett wrote:
>> >> 
>> >> From a packager POV, linking mplayer to an existing ffmpeg package's
>> >> libav* is an attractive option. Is there an easy way to not build
>> >> mplayers internal libav*, but to use one in ffmpeg's shared objects?
>> >> 
>> >> If not, could I encourage an option in the build system?
>> >
>> > ./configure --help
>> 
>> I reckon he is asking for something like
>> 
>> $ ./configure --with-system-ffmpeg
>> 
>> as shortcut for the various --disable_libavfoo_a options. Diego, at
>> FOSDEM, you've indicated sympathy with such a switch, has your opinion
>> changed since then? If not, I'll try to come up with a patch for that
>> next week when I'm back home.
>
> Go right ahead.

I don't know if this is the nicest patch, but it does work for me, and
produces a much nicer configuration string:

Index: configure
===================================================================
--- configure	(revision 31956)
+++ configure	(working copy)
@@ -355,6 +355,7 @@
   --disable-libavformat_so  disable shared libavformat [autodetect]
   --disable-libpostproc_so  disable shared libpostproc [autodetect]
   --disable-libswscale_so   disable shared libswscale [autodetect]
+  --enable-system-ffmpeg    disable shared ffmpeg libraries [no]
   --disable-libavcodec_mpegaudio_hp disable high precision audio decoding
                                     in libavcodec [enabled]
   --disable-tremor-internal disable internal Tremor [enabled]
@@ -588,6 +589,7 @@
 _libavcodec_a=auto
 _libavcore_a=auto
 _libavcore_so=auto
+_system_ffmpeg=no
 _libopencore_amrnb=auto
 _libopencore_amrwb=auto
 libopenjpeg=auto
@@ -1246,6 +1248,12 @@
   --disable-libswscale_a)       _libswscale_a=no        ;;
   --enable-libswscale_so)       _libswscale_so=yes      ;;
   --disable-libswscale_so)      _libswscale_so=no       ;;
+  --enable-system-ffmpeg)       _libavcore_a=no   ; _libavcore_so=yes
+                                _libavutil_a=no   ; _libavutil_so=yes
+                                _libavcodec_a=no  ; _libavcodec_so=yes
+                                _libswscale_a=no  ; _libswscale_so=yes 
+                                _libavformat_a=no ; _libavformat_so=yes
+                                _libpostproc_a=no ; _libpostproc_so=yes ;;
   --enable-libavcodec_mpegaudio_hp)     _libavcodec_mpegaudio_hp=yes    ;;
   --disable-libavcodec_mpegaudio_hp)    _libavcodec_mpegaudio_hp=no     ;;
 

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4